From: drh <>
Date: Thu, 2 May 2024 12:14:31 +0000 (+0000)
Subject: Fix the CREATE TABLE performance issue described by
X-Git-Tag: version-3.46.0~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d059774365c6e36640b924ca589a5dd815f7b5c9;p=thirdparty%2Fsqlite.git

Fix the CREATE TABLE performance issue described by
[forum:/forumpost/4cf69794d9dfff7c|forum thread 4cf69794d9dfff7c] in two
different ways:  (1) Omit the call to PRAGMA integrity_check('X') that was
being done after CREATE TABLE "X" because the result was being ignored and
the integrity_check was not doing anything other than burning CPU cycles.
(2) Do not interpret the argument to PRAGMA integrity_check as a number if it
is in fact a string that looks like a number.

FossilOrigin-Name: 71f08b912251c8a3ac1bd8e344903336648e4187f7493f8c126e60b3b51b9f09
---

d059774365c6e36640b924ca589a5dd815f7b5c9
diff --cc manifest
index 86cb7fabac,0582d49a23..7ed42d04e9
--- a/manifest
+++ b/manifest
@@@ -1,5 -1,5 +1,5 @@@
- C Fix\sanother\sproblem\sin\sthe\srecovery\sextension\swhere\sa\scorrupt\ssqlite_schema\stable\scould\slead\sto\sexcessive\smemory\sconsumption.
- D 2024-05-01T16:25:46.099
 -C Add\sa\stest\scase\sto\sthe\sfix\sto\sPRAGMA\sintegrity_check\sin\sthe\sprevious\scheck-in.
 -D 2024-05-02T12:00:36.739
++C Fix\sthe\sCREATE\sTABLE\sperformance\sissue\sdescribed\sby\n[forum:/forumpost/4cf69794d9dfff7c|forum\sthread\s4cf69794d9dfff7c]\sin\stwo\ndifferent\sways:\s\s(1)\sOmit\sthe\scall\sto\sPRAGMA\sintegrity_check('X')\sthat\swas\nbeing\sdone\safter\sCREATE\sTABLE\s"X"\sbecause\sthe\sresult\swas\sbeing\signored\sand\nthe\sintegrity_check\swas\snot\sdoing\sanything\sother\sthan\sburning\sCPU\scycles.\n(2)\sDo\snot\sinterpret\sthe\sargument\sto\sPRAGMA\sintegrity_check\sas\sa\snumber\sif\sit\nis\sin\sfact\sa\sstring\sthat\slooks\slike\sa\snumber.
++D 2024-05-02T12:14:31.463
  F .fossil-settings/empty-dirs dbb81e8fc0401ac46a1491ab34a7f2c7c0452f2f06b54ebb845d024ca8283ef1
  F .fossil-settings/ignore-glob 35175cdfcf539b2318cb04a9901442804be81cd677d8b889fcc9149c21f239ea
  F LICENSE.md df5091916dbb40e6e9686186587125e1b2ff51f022cc334e886c19a0e9982724
@@@ -2187,8 -2187,8 +2187,9 @@@ F vsixtest/vsixtest.tcl 6a9a6ab600c25a9
  F vsixtest/vsixtest.vcxproj.data 2ed517e100c66dc455b492e1a33350c1b20fbcdc
  F vsixtest/vsixtest.vcxproj.filters 37e51ffedcdb064aad6ff33b6148725226cd608e
  F vsixtest/vsixtest_TemporaryKey.pfx e5b1b036facdb453873e7084e1cae9102ccc67a0
- P 8de85170d53e1d2a2abe14508a222377b9493e25f3174b8f0f773427deb8df26
- R 2e43de06901a93042cb97fda0a6a1240
- U dan
- Z 503087664d848ee9e213d2cb778368c0
 -P b04e7a23478f1012e501a810f3e09cca81a66e802f5f72cae80c81120174e2cb
++P 1c7e33a8aa0e6122b5ef606e4a7d95e8ecd9440216d4b099fe8f2a40653422be 39a57b596d309d9e2d4c59409fe5d36e0665781ce0307d157ff8b6e883161bbb
+ R 0ac28bb5468fe4b54198e9b7f938f439
++T +closed 39a57b596d309d9e2d4c59409fe5d36e0665781ce0307d157ff8b6e883161bbb
+ U drh
 -Z 39f04eb486031705b188423b1deb4083
++Z 15b2c37a84e486735d2d03d1b8398070
  # Remove this line to create a well-formed Fossil manifest.
diff --cc manifest.uuid
index f2af8cbeb6,37970c7581..8ac80e7da6
--- a/manifest.uuid
+++ b/manifest.uuid
@@@ -1,1 -1,1 +1,1 @@@
- 1c7e33a8aa0e6122b5ef606e4a7d95e8ecd9440216d4b099fe8f2a40653422be
 -39a57b596d309d9e2d4c59409fe5d36e0665781ce0307d157ff8b6e883161bbb
++71f08b912251c8a3ac1bd8e344903336648e4187f7493f8c126e60b3b51b9f09