From: Even Xu Date: Thu, 13 Feb 2025 02:40:21 +0000 (+0800) Subject: Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue X-Git-Tag: v6.15-rc1~171^2~8^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d05c76fceb096b4423745856325d72c048d681e4;p=thirdparty%2Flinux.git Hid: Intel-thc-hid: Intel-thc: Fix "dubious: !x | !y" issue Change to use "||" to make it more readable and avoid miss understanding. Signed-off-by: Even Xu Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202501292144.eFDq4ovr-lkp@intel.com Signed-off-by: Jiri Kosina --- diff --git a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c index eb23bea776864..8f97e71df7f41 100644 --- a/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c +++ b/drivers/hid/intel-thc-hid/intel-thc/intel-thc-dma.c @@ -295,7 +295,7 @@ static void release_dma_buffers(struct thc_device *dev, return; for (i = 0; i < config->prd_tbl_num; i++) { - if (!config->sgls[i] | !config->sgls_nent[i]) + if (!config->sgls[i] || !config->sgls_nent[i]) continue; dma_unmap_sg(dev->dev, config->sgls[i],