From: Sami Kerola <kerolasa@iki.fi>
Date: Sat, 31 Oct 2015 19:21:15 +0000 (+0000)
Subject: fsck: retire stat(3) when access(3) does better job
X-Git-Tag: v2.28-rc1~283
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d0a050e0f9343f3da7c3b865eff78ce36df14f2c;p=thirdparty%2Futil-linux.git

fsck: retire stat(3) when access(3) does better job

The stat(3) and access(3) are in this case almost interchangeable, so choose
the lightweight function with additional advantage checking the file is
executable.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
---

diff --git a/disk-utils/fsck.c b/disk-utils/fsck.c
index ff504aa1da..5be2b44d7d 100644
--- a/disk-utils/fsck.c
+++ b/disk-utils/fsck.c
@@ -547,14 +547,13 @@ static char *find_fsck(const char *type)
 	const char *tpl;
 	static char prog[256];
 	char *p = xstrdup(fsck_path);
-	struct stat st;
 
 	/* Are we looking for a program or just a type? */
 	tpl = (strncmp(type, "fsck.", 5) ? "%s/fsck.%s" : "%s/%s");
 
 	for(s = strtok(p, ":"); s; s = strtok(NULL, ":")) {
 		sprintf(prog, tpl, s, type);
-		if (stat(prog, &st) == 0)
+		if (access(prog, X_OK) == 0)
 			break;
 	}
 	free(p);