From: Nicholas Bishop Date: Fri, 12 May 2023 19:43:02 +0000 (+0000) Subject: efi/esrt: Allow ESRT access without CAP_SYS_ADMIN X-Git-Tag: v6.5-rc1~107^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d0a1865cf7e2211d9227592ef4141f4632e33908;p=thirdparty%2Fkernel%2Flinux.git efi/esrt: Allow ESRT access without CAP_SYS_ADMIN Access to the files in /sys/firmware/efi/esrt has been restricted to CAP_SYS_ADMIN since support for ESRT was added, but this seems overly restrictive given that the files are read-only and just provide information about UEFI firmware updates. Remove the CAP_SYS_ADMIN restriction so that a non-root process can read the files, provided a suitably-privileged process changes the file ownership first. The files are still read-only and still owned by root by default. Signed-off-by: Nicholas Bishop Signed-off-by: Ard Biesheuvel --- diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index c61398634d75f..7a81c0ce47805 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -95,10 +95,6 @@ static ssize_t esre_attr_show(struct kobject *kobj, struct esre_entry *entry = to_entry(kobj); struct esre_attribute *attr = to_attr(_attr); - /* Don't tell normal users what firmware versions we've got... */ - if (!capable(CAP_SYS_ADMIN)) - return -EACCES; - return attr->show(entry, buf); }