From: Guangqing Zhu <zhuguangqing83@gmail.com>
Date: Wed, 21 Apr 2021 14:36:50 +0000 (+0800)
Subject: power: supply: cpcap-battery: fix invalid usage of list cursor
X-Git-Tag: v5.13-rc1~112^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d0a43c12ee9f57ddb284272187bd18726c2c2c98;p=thirdparty%2Fkernel%2Flinux.git

power: supply: cpcap-battery: fix invalid usage of list cursor

Fix invalid usage of a list_for_each_entry in cpcap_battery_irq_thread().
Empty list or fully traversed list points to list head, which is not
NULL (and before the first element containing real data).

Signed-off-by: Guangqing Zhu <zhuguangqing83@gmail.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Reviewed-by: Carl Philipp Klemm <philipp@uvos.xyz>
Tested-by: Carl Philipp Klemm <philipp@uvos.xyz>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---

diff --git a/drivers/power/supply/cpcap-battery.c b/drivers/power/supply/cpcap-battery.c
index 6d5bcdb9f45d6..a3fc0084cda00 100644
--- a/drivers/power/supply/cpcap-battery.c
+++ b/drivers/power/supply/cpcap-battery.c
@@ -786,7 +786,7 @@ static irqreturn_t cpcap_battery_irq_thread(int irq, void *data)
 			break;
 	}
 
-	if (!d)
+	if (list_entry_is_head(d, &ddata->irq_list, node))
 		return IRQ_NONE;
 
 	latest = cpcap_battery_latest(ddata);