From: Björn Baumbach Date: Wed, 26 Feb 2020 12:38:50 +0000 (+0100) Subject: samba-tool group listmembers: use binary encoded group names X-Git-Tag: ldb-2.2.0~1553 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d0f8e833653df652df01a472c4bbfd256f10f810;p=thirdparty%2Fsamba.git samba-tool group listmembers: use binary encoded group names Allows to find groups with names like e.g. 'group1 (xy)'. BUG: https://bugzilla.samba.org/show_bug.cgi?id=14296 Signed-off-by: Björn Baumbach Reviewed-by: Andrew Bartlett --- diff --git a/python/samba/netcmd/group.py b/python/samba/netcmd/group.py index e3116ee71c4..c56eb2d3354 100644 --- a/python/samba/netcmd/group.py +++ b/python/samba/netcmd/group.py @@ -516,7 +516,8 @@ samba-tool group listmembers \"Domain Users\" -H ldap://samba.samdom.example.com samdb = SamDB(url=H, session_info=system_session(), credentials=creds, lp=lp) - search_filter = "(&(objectClass=group)(samaccountname=%s))" % groupname + search_filter = ("(&(objectClass=group)(sAMAccountName=%s))" % + ldb.binary_encode(groupname)) try: res = samdb.search(samdb.domain_dn(), scope=ldb.SCOPE_SUBTREE, expression=(search_filter),