From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Tue, 24 Mar 2020 20:05:17 +0000 (+0100)
Subject: lib-smtp: smtp-server-cmd-vrfy - Restructure parameter parsing.
X-Git-Tag: 2.3.10.1~17
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d143ca6b7ee1196ae3eafffbf6dee71a95a5e0b8;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp-server-cmd-vrfy - Restructure parameter parsing.
---

diff --git a/src/lib-smtp/smtp-server-cmd-vrfy.c b/src/lib-smtp/smtp-server-cmd-vrfy.c
index 56019d7e25..6d6537b4f0 100644
--- a/src/lib-smtp/smtp-server-cmd-vrfy.c
+++ b/src/lib-smtp/smtp-server-cmd-vrfy.c
@@ -17,15 +17,13 @@ void smtp_server_cmd_vrfy(struct smtp_server_cmd_ctx *cmd,
 	int ret;
 
 	/* vrfy = "VRFY" SP String CRLF */
-	if ((ret=smtp_string_parse(params, &param, &error)) <= 0) {
-		if (ret < 0) {
-			smtp_server_reply(cmd,
-				501, "5.5.4",
-				"Invalid string parameter: %s", error);
-		} else {
-			smtp_server_reply(cmd,
-				501, "5.5.4", "Invalid parameters");
-		}
+	ret = smtp_string_parse(params, &param, &error);
+	if (ret < 0) {
+		smtp_server_reply(cmd, 501, "5.5.4",
+				  "Invalid string parameter: %s", error);
+		return;
+	} else if (ret == 0) {
+		smtp_server_reply(cmd, 501, "5.5.4", "Invalid parameters");
 		return;
 	}