From: Willy Tarreau <w@1wt.eu>
Date: Mon, 27 Jul 2026 09:02:52 +0000 (+0200)
Subject: CLEANUP: htx: remove the unreachable "append_data" label in htx_reserve_max_data()
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d159dc6ff2d9594e9ea5201164435df71fe63128;p=thirdparty%2Fhaproxy.git

CLEANUP: htx: remove the unreachable "append_data" label in htx_reserve_max_data()

htx_reserve_max_data() carries an "append_data:" label which is never the target
of a goto: the function simply falls through it. It looks like a leftover from
htx_add_data(), which does use such a label. Let's drop it, the code is reached
by fallthrough anyway and an unused label is only confusing.
---

diff --git a/src/htx.c b/src/htx.c
index 7143e3961..4d2d4cf95 100644
--- a/src/htx.c
+++ b/src/htx.c
@@ -1185,7 +1185,6 @@ struct htx_ret htx_reserve_max_data(struct htx *htx)
 	if (room < len)
 		len = room;
 
-append_data:
 	htx_change_blk_value_len(htx, tailblk, sz+len);
 
 	BUG_ON((int32_t)htx->tail_addr < 0);