From: Amaury Denoyelle <adenoyelle@haproxy.com>
Date: Mon, 15 Nov 2021 14:52:55 +0000 (+0100)
Subject: BUG/MINOR: h3: ignore unknown frame types
X-Git-Tag: v2.5-dev15~43
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d1acaf9828d1a95bdefb73ff637e3c467a9fb7ac;p=thirdparty%2Fhaproxy.git

BUG/MINOR: h3: ignore unknown frame types

When receiving an unknown h3 frame type, the frame must be discarded
silently and the processing of the remaing frames must continue. This is
according to the HTTP/3 draft34.

This issue was detected when using the quiche client which uses GREASE
frame to test interoperability.
---

diff --git a/src/h3.c b/src/h3.c
index 20f202c2e7..352b8c2d03 100644
--- a/src/h3.c
+++ b/src/h3.c
@@ -212,9 +212,10 @@ static int h3_decode_qcs(struct qcs *qcs, void *ctx)
 			/* Not supported */
 			break;
 		default:
-			/* Error */
-			h3->err = H3_FRAME_UNEXPECTED;
-			return -1;
+			/* draft-ietf-quic-http34 9. Extensions to HTTP/3
+			 * unknown frame types MUST be ignored
+			 */
+			h3_debug_printf(stderr, "ignore unknown frame type 0x%lx\n", ftype);
 		}
 		b_del(rxbuf, flen);
 	}