From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 19 Sep 2018 10:35:00 +0000 (+0300)
Subject: thermal: armada: fix a test in probe()
X-Git-Tag: v4.20-rc1~104^2~22
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d1d2c290b3c04b65fa6132eeebe50a070746d8f6;p=thirdparty%2Fkernel%2Flinux.git

thermal: armada: fix a test in probe()

The platform_get_resource() function doesn't return error pointers, it
returns NULL on error.

Fixes: 3d4e51844a4e ("thermal: armada: convert driver to syscon register accesses")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Eduardo Valentin <edubezval@gmail.com>
---

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 2c2f6d93034ec..92f67d40f2e96 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -526,8 +526,8 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev,
 
 	/* First memory region points towards the status register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (IS_ERR(res))
-		return PTR_ERR(res);
+	if (!res)
+		return -EIO;
 
 	/*
 	 * Edit the resource start address and length to map over all the