From: Haowen Bai Date: Fri, 1 Apr 2022 03:41:16 +0000 (+0800) Subject: video: fbdev: sis: fix potential NULL dereference in sisfb_post_sis300() X-Git-Tag: v5.18-rc5~35^2~16 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d1d608ce78b3fc330938faaa1f70a91cf20c03a9;p=thirdparty%2Flinux.git video: fbdev: sis: fix potential NULL dereference in sisfb_post_sis300() Do no access bios[] if it's NULL. Signed-off-by: Haowen Bai Signed-off-by: Helge Deller --- diff --git a/drivers/video/fbdev/sis/sis_main.c b/drivers/video/fbdev/sis/sis_main.c index 742f62986b80b..f28fd69d5eb75 100644 --- a/drivers/video/fbdev/sis/sis_main.c +++ b/drivers/video/fbdev/sis/sis_main.c @@ -4463,7 +4463,7 @@ static void sisfb_post_sis300(struct pci_dev *pdev) SiS_SetReg(SISCR, 0x37, 0x02); SiS_SetReg(SISPART2, 0x00, 0x1c); v4 = 0x00; v5 = 0x00; v6 = 0x10; - if(ivideo->SiS_Pr.UseROM) { + if (ivideo->SiS_Pr.UseROM && bios) { v4 = bios[0xf5]; v5 = bios[0xf6]; v6 = bios[0xf7];