From: Christos Tsantilas <chtsanti@users.sourceforge.net>
Date: Tue, 25 Sep 2012 14:51:20 +0000 (+0300)
Subject: Bug fix: The ACLFilledChecklist::fd set with wrong fd for Config.ssl_client.cert_erro... 
X-Git-Tag: SQUID_3_3_0_1~40
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d20cad0ae40d1343aa4a917137b89133ba598719;p=thirdparty%2Fsquid.git

Bug fix: The ACLFilledChecklist::fd set with wrong fd for Config.ssl_client.cert_error acl list

The Config.ssl_client.cert_error uses the server-side connection fd instead of
the client-side connection fd.
---

diff --git a/src/client_side.cc b/src/client_side.cc
index 84db45fc67..1ad470d08b 100644
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -2516,8 +2516,6 @@ bool ConnStateData::serveDelayedError(ClientSocketContext *context)
 
             ACLFilledChecklist check(Config.ssl_client.cert_error, request, dash_str);
             check.sslErrors = new Ssl::Errors(SQUID_X509_V_ERR_DOMAIN_MISMATCH);
-            if (Comm::IsConnOpen(pinning.serverConnection))
-                check.fd(pinning.serverConnection->fd);
             const bool allowDomainMismatch =
                 check.fastCheck() == ACCESS_ALLOWED;
             delete check.sslErrors;