From: John Snow <jsnow@redhat.com>
Date: Thu, 3 Jun 2021 00:37:09 +0000 (-0400)
Subject: python: Add 'fh' to known-good variable names
X-Git-Tag: v6.1.0-rc0~66^2~63
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d229f1c83d698ed5f605bcc2eab96e05afeddefb;p=thirdparty%2Fqemu.git

python: Add 'fh' to known-good variable names

fd and fh are fine: we often use these for "file descriptor" or "file
handle" accordingly. It is rarely the case that you need to enforce a
more semantically meaningful name beyond "This is the file we are using
right now."

While we're here: add comments for all of the non-standard pylint
names. (And the underscore.)

Signed-off-by: John Snow <jsnow@redhat.com>
Message-id: 20210603003719.1321369-10-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
---

diff --git a/python/setup.cfg b/python/setup.cfg
index a19029d5388..c9b9445af98 100644
--- a/python/setup.cfg
+++ b/python/setup.cfg
@@ -78,9 +78,10 @@ good-names=i,
            k,
            ex,
            Run,
-           _,
-           fd,
-           c,
+           _,   # By convention: Unused variable
+           fh,  # fh = open(...)
+           fd,  # fd = os.open(...)
+           c,   # for c in string: ...
 
 [pylint.similarities]
 # Ignore imports when computing similarities.