From: Rafael J. Wysocki Date: Thu, 27 Feb 2025 10:56:12 +0000 (+0100) Subject: PM: runtime: Drop status check from pm_runtime_force_resume() X-Git-Tag: v6.15-rc1~191^2~2^3~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d2677d57d4b8ec63da8f51357bcf855c4cf47c78;p=thirdparty%2Fkernel%2Flinux.git PM: runtime: Drop status check from pm_runtime_force_resume() Since pm_runtime_force_resume() requires pm_runtime_force_suspend() to be called before it on the same device, the runtime PM status of the device is RPM_SUSPENDED when it is called unless the device's runtime PM status is changed somewhere else in the meantime. However, even if that happens, the power.needs_force_resume check is still required to pass and that flag is only set by pm_runtime_force_suspend() once and it is cleared at the end of pm_runtime_force_resume(), so it cannot be taken into account twice in a row. According to the above, the pm_runtime_status_suspended(dev) check in pm_runtime_force_resume() is redundant, so drop it. Signed-off-by: Rafael J. Wysocki Reviewed-by: Ulf Hansson Link: https://patch.msgid.link/2309120.iZASKD2KPV@rjwysocki.net --- diff --git a/drivers/base/power/runtime.c b/drivers/base/power/runtime.c index a5aed89e1a6b8..1714358b541e8 100644 --- a/drivers/base/power/runtime.c +++ b/drivers/base/power/runtime.c @@ -1945,7 +1945,7 @@ int pm_runtime_force_resume(struct device *dev) int (*callback)(struct device *); int ret = 0; - if (!pm_runtime_status_suspended(dev) || !dev->power.needs_force_resume) + if (!dev->power.needs_force_resume) goto out; /*