From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Thu, 15 Feb 2018 16:16:15 +0000 (+0200)
Subject: imap: Don't set storage callbacks before namespaces are created
X-Git-Tag: 2.2.35~37
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d26c81ddcb28e26a96799da663b52f34f350cc43;p=thirdparty%2Fdovecot%2Fcore.git

imap: Don't set storage callbacks before namespaces are created

This fixes sending untagged OK/NO notifications from storage (e.g. lock
waits/override notifications). It was broken by
e031d9aaae59a9f79710dc1138b76b69272615a3
---

diff --git a/src/imap/imap-client.c b/src/imap/imap-client.c
index f6cd485288..ff6494be44 100644
--- a/src/imap/imap-client.c
+++ b/src/imap/imap-client.c
@@ -153,9 +153,6 @@ struct client *client_create(int fd_in, int fd_out, const char *session_id,
 					     &client->output);
 	}
 
-	mail_namespaces_set_storage_callbacks(user->namespaces,
-					      &mail_storage_callbacks, client);
-
 	client->capability_string =
 		str_new(client->pool, sizeof(CAPABILITY_STRING)+64);
 
@@ -220,6 +217,8 @@ int client_create_finish(struct client *client, const char **error_r)
 {
 	if (mail_namespaces_init(client->user, error_r) < 0)
 		return -1;
+	mail_namespaces_set_storage_callbacks(client->user->namespaces,
+					      &mail_storage_callbacks, client);
 	return 0;
 }