From: Frédéric Lécaille <flecaille@haproxy.com>
Date: Thu, 21 Jul 2022 07:55:15 +0000 (+0200)
Subject: BUG/MINOR: quic: loss time limit variable computed but not used
X-Git-Tag: v2.7-dev3~53
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d2e104ff78ddfb613b3c710e3ac747d2b61c9f99;p=thirdparty%2Fhaproxy.git

BUG/MINOR: quic: loss time limit variable computed but not used

<loss_time_limit> is the loss time limit computed from <time_sent> packet
transmission timestamps in qc_packet_loss_lookup() to identify the packets which
have been lost. This latter timestamp variable was used in place of
<loss_time_limit> to distinguish such packets from others (still in fly packets).

Must be backported to 2.6
---

diff --git a/src/quic_loss.c b/src/quic_loss.c
index 72f5a28ea3..7cce3a4788 100644
--- a/src/quic_loss.c
+++ b/src/quic_loss.c
@@ -173,7 +173,7 @@ void qc_packet_loss_lookup(struct quic_pktns *pktns, struct quic_conn *qc,
 
 		time_sent = pkt->time_sent;
 		loss_time_limit = tick_add(time_sent, loss_delay);
-		if (tick_is_le(time_sent, now_ms) ||
+		if (tick_is_le(loss_time_limit, now_ms) ||
 			(int64_t)largest_acked_pn >= pkt->pn_node.key + QUIC_LOSS_PACKET_THRESHOLD) {
 			eb64_delete(&pkt->pn_node);
 			LIST_APPEND(lost_pkts, &pkt->list);