From: Joe Orton <jorton@apache.org>
Date: Fri, 3 Dec 2021 16:40:18 +0000 (+0000)
Subject: * support/ab.c (main): Check apr_getopt() returned APR_EOF, fixing clang
X-Git-Tag: 2.5.0-alpha2-ci-test-only~666
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d318188682d3577a0feea348657d25192c7f513f;p=thirdparty%2Fapache%2Fhttpd.git

* support/ab.c (main): Check apr_getopt() returned APR_EOF, fixing clang
 warning:

support/ab.c:2343:13: warning[deadcode.DeadStores]: Although the value stored to 'status' is used in the enclosing expression, the value is never actually read from 'status'


git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1895559 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/support/ab.c b/support/ab.c
index f4a68662f64..55d1e4bb88a 100644
--- a/support/ab.c
+++ b/support/ab.c
@@ -2592,8 +2592,8 @@ int main(int argc, const char * const argv[])
         }
     }
 
-    if (opt->ind != argc - 1) {
-        fprintf(stderr, "%s: wrong number of arguments\n", argv[0]);
+    if (status != APR_EOF || opt->ind != argc - 1) {
+        fprintf(stderr, "%s: Invalid or missing arguments\n", argv[0]);
         usage(argv[0]);
     }