From: Nick Porter <nick@portercomputing.co.uk>
Date: Fri, 17 Oct 2025 09:09:39 +0000 (+0100)
Subject: Just return -1 for errors (it's all the callers check) (CID #1667131)
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d321e9aa2d0b721de4f725d8a6c24d2156a1632c;p=thirdparty%2Ffreeradius-server.git

Just return -1 for errors (it's all the callers check) (CID #1667131)
---

diff --git a/src/protocols/dhcpv4/packet.c b/src/protocols/dhcpv4/packet.c
index 12d7ebbe5c..a467adab81 100644
--- a/src/protocols/dhcpv4/packet.c
+++ b/src/protocols/dhcpv4/packet.c
@@ -219,7 +219,7 @@ int fr_dhcpv4_decode(TALLOC_CTX *ctx, fr_pair_list_t *out, uint8_t const *data,
 			fail:
 				fr_pair_list_free(&tmp);
 				talloc_free(packet_ctx);
-				return len;
+				return -1;
 			}
 			p += len;
 		}