From: Zhang Zekun Date: Fri, 16 Aug 2024 02:18:26 +0000 (+0800) Subject: ALSA: aoa: Use helper function for_each_child_of_node() X-Git-Tag: v6.12-rc1~169^2~55 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d32cf9fbcb613a8f43e2211e964ccc8bb7271dcf;p=thirdparty%2Fkernel%2Flinux.git ALSA: aoa: Use helper function for_each_child_of_node() for_each_child_of_node can help to iterate through the device_node, and we don't need to use while loop. No functional change with this conversion. Signed-off-by: Zhang Zekun Link: https://patch.msgid.link/20240816021826.65190-1-zhangzekun11@huawei.com Signed-off-by: Takashi Iwai --- diff --git a/sound/aoa/soundbus/i2sbus/core.c b/sound/aoa/soundbus/i2sbus/core.c index 5431d2c494210..ce84288168e45 100644 --- a/sound/aoa/soundbus/i2sbus/core.c +++ b/sound/aoa/soundbus/i2sbus/core.c @@ -335,7 +335,7 @@ static int i2sbus_add_dev(struct macio_dev *macio, static int i2sbus_probe(struct macio_dev* dev, const struct of_device_id *match) { - struct device_node *np = NULL; + struct device_node *np; int got = 0, err; struct i2sbus_control *control = NULL; @@ -347,7 +347,7 @@ static int i2sbus_probe(struct macio_dev* dev, const struct of_device_id *match) return -ENODEV; } - while ((np = of_get_next_child(dev->ofdev.dev.of_node, np))) { + for_each_child_of_node(dev->ofdev.dev.of_node, np) { if (of_device_is_compatible(np, "i2sbus") || of_device_is_compatible(np, "i2s-modem")) { got += i2sbus_add_dev(dev, control, np);