From: Robin Roevens <robin.roevens@disroot.org>
Date: Tue, 10 Sep 2024 21:32:32 +0000 (+0200)
Subject: header.pl: only get memory consumption when service is running
X-Git-Tag: v2.29-core189~65^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d335cc9592afa74f219bbf564b01c612ea336e77;p=ipfire-2.x.git

header.pl: only get memory consumption when service is running

It probably doesn't matter much as the get_memory_consumption function just returns 0 when no pids are found. But it shouldn't even try as the mem var is never used when the service is not running.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/config/cfgroot/header.pl b/config/cfgroot/header.pl
index a90a6f4817..3778c4e599 100644
--- a/config/cfgroot/header.pl
+++ b/config/cfgroot/header.pl
@@ -950,9 +950,6 @@ EOF
 			@pids = &General::find_pids("${process}");
 		}
 
-		# Get memory consumption
-		my $mem = &General::get_memory_consumption(@pids);
-
 		print <<EOF;
 				<tr>
 					<th scope="row">
@@ -962,6 +959,9 @@ EOF
 
 		# Running?
 		if (scalar @pids) {
+			# Get memory consumption
+			my $mem = &General::get_memory_consumption(@pids);
+
 			# Format memory
 			$mem = &General::formatBytes($mem);