From: Stephan Bosch <stephan.bosch@open-xchange.com>
Date: Sat, 21 Jun 2025 16:09:22 +0000 (+0200)
Subject: lib-smtp: smtp-client-command - Always use smtp_client_command_drop_callback() to... 
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d344c3327f2e9db252a36d8efb9c8bdf1e3ff009;p=thirdparty%2Fdovecot%2Fcore.git

lib-smtp: smtp-client-command - Always use smtp_client_command_drop_callback() to clear callback

For consistency.
---

diff --git a/src/lib-smtp/smtp-client-command.c b/src/lib-smtp/smtp-client-command.c
index f4f17f1d4d..5b763a7a10 100644
--- a/src/lib-smtp/smtp-client-command.c
+++ b/src/lib-smtp/smtp-client-command.c
@@ -304,6 +304,7 @@ void smtp_client_command_fail_reply(struct smtp_client_command **_cmd,
 	struct smtp_client_connection *conn = cmd->conn;
 	enum smtp_client_command_state state = cmd->state;
 	smtp_client_command_callback_t *callback = cmd->callback;
+	void *context = cmd->context;
 
 	if (state >= SMTP_CLIENT_COMMAND_STATE_FINISHED)
 		return;
@@ -324,8 +325,7 @@ void smtp_client_command_fail_reply(struct smtp_client_command **_cmd,
 		return;
 	}
 
-	cmd->callback = NULL;
-
+	smtp_client_command_drop_callback(cmd);
 	smtp_client_connection_ref(conn);
 	smtp_client_command_ref(cmd);
 
@@ -342,7 +342,7 @@ void smtp_client_command_fail_reply(struct smtp_client_command **_cmd,
 		e_debug(e->event(), "Failed: %s", smtp_reply_log(reply));
 
 		if (callback != NULL)
-			(void)callback(reply, cmd->context);
+			(void)callback(reply, context);
 	}
 
 	tmp_cmd = cmd;