From: Tim Duesterhus <tim@bastelstu.be>
Date: Sat, 18 Jan 2020 00:46:18 +0000 (+0100)
Subject: BUG/MINOR: cache: Fix leak of cache name in error path
X-Git-Tag: v2.2-dev1~81
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d34b1ce5a20ce8f62b234f9696a621aaebe694c1;p=thirdparty%2Fhaproxy.git

BUG/MINOR: cache: Fix leak of cache name in error path

This issue was introduced in commit 99a17a2d91f9044ea20bba6617048488aed80555
which first appeared in tag v1.9-dev11. This bugfix should be backported
to HAProxy 1.9+.
---

diff --git a/src/cache.c b/src/cache.c
index 8e2acd1cb1..dc11cf5320 100644
--- a/src/cache.c
+++ b/src/cache.c
@@ -1452,7 +1452,7 @@ parse_cache_flt(char **args, int *cur_arg, struct proxy *px,
 			cconf = NULL;
 			memprintf(err, "%s: multiple explicit declarations of the cache filter '%s'",
 				  px->id, name);
-			return -1;
+			goto error;
 		}
 
 		/* Remove the implicit filter. <cconf> is kept for the explicit one */