From: Alan Modra Date: Fri, 4 Mar 2011 01:44:21 +0000 (+0000) Subject: * archive.c (bsd_write_armap): Don't call stat in deterministic X-Git-Tag: binutils-2_21_1~167 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d3945216ce77e3b0e7c0b5980b380ae98713b75f;p=thirdparty%2Fbinutils-gdb.git * archive.c (bsd_write_armap): Don't call stat in deterministic mode, and don't use st_mtime if stat returns error. --- diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 6fd48352fd8..3871a6aa977 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,8 @@ +2011-03-04 Alan Modra + + * archive.c (bsd_write_armap): Don't call stat in deterministic + mode, and don't use st_mtime if stat returns error. + 2011-02-28 Alan Modra PR 12513 diff --git a/bfd/archive.c b/bfd/archive.c index c3aaffc59f5..74c28842574 100644 --- a/bfd/archive.c +++ b/bfd/archive.c @@ -2299,31 +2299,28 @@ bsd_write_armap (bfd *arch, bfd_byte temp[4]; unsigned int count; struct ar_hdr hdr; - struct stat statbuf; long uid, gid; firstreal = mapsize + elength + sizeof (struct ar_hdr) + SARMAG; - stat (arch->filename, &statbuf); + /* If deterministic, we use 0 as the timestamp in the map. + Some linkers may require that the archive filesystem modification + time is less than (or near to) the archive map timestamp. Those + linkers should not be used with deterministic mode. (GNU ld and + Gold do not have this restriction.) */ + bfd_ardata (arch)->armap_timestamp = 0; + uid = 0; + gid = 0; if ((arch->flags & BFD_DETERMINISTIC_OUTPUT) == 0) { - /* Remember the timestamp, to keep it holy. But fudge it a little. */ - bfd_ardata (arch)->armap_timestamp = (statbuf.st_mtime - + ARMAP_TIME_OFFSET); + struct stat statbuf; + + if (stat (arch->filename, &statbuf) == 0) + bfd_ardata (arch)->armap_timestamp = (statbuf.st_mtime + + ARMAP_TIME_OFFSET); uid = getuid(); gid = getgid(); } - else - { - /* If deterministic, we use 0 as the timestamp in the map. - Some linkers may require that the archive filesystem modification - time is less than (or near to) the archive map timestamp. Those - linkers should not be used with deterministic mode. (GNU ld and - Gold do not have this restriction.) */ - bfd_ardata (arch)->armap_timestamp = 0; - uid = 0; - gid = 0; - } memset (&hdr, ' ', sizeof (struct ar_hdr)); memcpy (hdr.ar_name, RANLIBMAG, strlen (RANLIBMAG));