From: Dan Carpenter Date: Mon, 12 Aug 2024 06:43:05 +0000 (+0300) Subject: iio: proximity: hx9023s: Fix error code in hx9023s_property_get() X-Git-Tag: v6.12-rc1~39^2~37^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d3bde2243d42a3b857fe72282ed1c19c82bd6e36;p=thirdparty%2Fkernel%2Flinux.git iio: proximity: hx9023s: Fix error code in hx9023s_property_get() If we're returning because "reg >= HX9023S_CH_NUM" then set the error code to -ENIVAL instead of success. Fixes: 60df548277b7 ("iio: proximity: Add driver support for TYHX's HX9023S capacitive proximity sensor") Signed-off-by: Dan Carpenter Link: https://patch.msgid.link/49b5a9bc-e5ca-43a7-a665-313eb06fbe27@stanley.mountain Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/proximity/hx9023s.c b/drivers/iio/proximity/hx9023s.c index fe14a62a13428..8b9f84400e004 100644 --- a/drivers/iio/proximity/hx9023s.c +++ b/drivers/iio/proximity/hx9023s.c @@ -598,7 +598,8 @@ static int hx9023s_property_get(struct hx9023s_data *data) device_for_each_child_node_scoped(dev, child) { ret = fwnode_property_read_u32(child, "reg", ®); if (ret || reg >= HX9023S_CH_NUM) - return dev_err_probe(dev, ret, "Failed to read reg\n"); + return dev_err_probe(dev, ret < 0 ? ret : -EINVAL, + "Failed to read reg\n"); __set_bit(reg, &data->chan_in_use); ret = fwnode_property_read_u32(child, "single-channel", &temp);