From: Dan Carpenter Date: Tue, 17 Nov 2020 07:22:51 +0000 (+0300) Subject: platform/x86: pmt: Fix a potential Oops on error in probe X-Git-Tag: v5.11-rc1~154^2~32 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d3d73d25e0d9bc43fd2a6f4b4e58ff182e55b217;p=thirdparty%2Flinux.git platform/x86: pmt: Fix a potential Oops on error in probe The "ns->attr_grp" pointer can be NULL so this error handling code needs to check for that to avoid an Oops. Fixes: e2729113ce66 ("platform/x86: Intel PMT class driver") Signed-off-by: Dan Carpenter Reviewed-by: David E. Box Link: https://lore.kernel.org/r/20201117072251.GC1111239@mwanda Signed-off-by: Hans de Goede --- diff --git a/drivers/platform/x86/intel_pmt_class.c b/drivers/platform/x86/intel_pmt_class.c index aa88dc23bbde6..c8939fba45090 100644 --- a/drivers/platform/x86/intel_pmt_class.c +++ b/drivers/platform/x86/intel_pmt_class.c @@ -225,7 +225,8 @@ static int intel_pmt_dev_register(struct intel_pmt_entry *entry, return 0; fail_ioremap: - sysfs_remove_group(entry->kobj, ns->attr_grp); + if (ns->attr_grp) + sysfs_remove_group(entry->kobj, ns->attr_grp); fail_sysfs: device_unregister(dev); fail_dev_create: