From: Anton Moryakov <ant.v.moryakov@gmail.com>
Date: Thu, 13 Feb 2025 15:57:42 +0000 (+0300)
Subject: readelf: check elf_getarhdr returns NULL in dump_archive_index
X-Git-Tag: elfutils-0.193~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d40e0808309babcf2c88864aa3acef23f1fd3a70;p=thirdparty%2Felfutils.git

readelf: check elf_getarhdr returns NULL in dump_archive_index

Report of the static analyzer:
DEREF_OF_NULL.RET Pointer, returned from function 'elf_getarhdr' at
readelf.c:13551, may be NULL and is dereferenced at readelf.c:13553.

    * src/readelf.c (dump_archive_index): Check elf_getarhdr doesn't
    return NULL.

Triggers found by static analyzer Svace.

Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com>
---

diff --git a/src/readelf.c b/src/readelf.c
index da379216..61d5b71a 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -13561,8 +13561,8 @@ dump_archive_index (Elf *elf, const char *fname)
 			  as_off, fname, elf_errmsg (-1));
 
 	  const Elf_Arhdr *h = elf_getarhdr (subelf);
-
-	  printf (_("Archive member '%s' contains:\n"), h->ar_name);
+	  if (h != NULL)
+	    printf (_("Archive member '%s' contains:\n"), h->ar_name);
 
 	  elf_end (subelf);
 	}