From: Andrew Morton Date: Tue, 25 Jun 2024 21:51:36 +0000 (-0700) Subject: mm/huge_memory.c: fix used-uninitialized X-Git-Tag: v6.11-rc1~85^2~239 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d40f74ab9d6158979a20957ead0e0dec7040ec37;p=thirdparty%2Fkernel%2Flinux.git mm/huge_memory.c: fix used-uninitialized Fix used-uninitialized of `page'. Fixes: dce7d10be4bb ("mm/madvise: optimize lazyfreeing with mTHP in madvise_free") Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202406260514.SLhNM9kQ-lkp@intel.com Cc: Lance Yang Signed-off-by: Andrew Morton --- diff --git a/mm/huge_memory.c b/mm/huge_memory.c index 18bcd7672a89b..46ba81240d969 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -2696,7 +2696,6 @@ static bool __discard_anon_folio_pmd_locked(struct vm_area_struct *vma, struct mm_struct *mm = vma->vm_mm; int ref_count, map_count; pmd_t orig_pmd = *pmdp; - struct page *page; if (folio_test_dirty(folio) || pmd_dirty(orig_pmd)) return false; @@ -2732,7 +2731,7 @@ static bool __discard_anon_folio_pmd_locked(struct vm_area_struct *vma, return false; } - folio_remove_rmap_pmd(folio, page, vma); + folio_remove_rmap_pmd(folio, pmd_page(orig_pmd), vma); zap_deposited_table(mm, pmdp); add_mm_counter(mm, MM_ANONPAGES, -HPAGE_PMD_NR); if (vma->vm_flags & VM_LOCKED)