From: David Hildenbrand Date: Mon, 10 Feb 2025 08:46:45 +0000 (+0100) Subject: physmem: disallow direct access to RAM DEVICE in address_space_write_rom() X-Git-Tag: v10.0.0-rc0~46^2~9 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d4337aa8e222802d342b9f58440ca8e005b8bf91;p=thirdparty%2Fqemu.git physmem: disallow direct access to RAM DEVICE in address_space_write_rom() As documented in commit 4a2e242bbb306 ("memory: Don't use memcpy for ram_device regions"), we disallow direct access to RAM DEVICE regions. This change implies that address_space_write_rom() and cpu_memory_rw_debug() won't be able to write to RAM DEVICE regions. It will also affect cpu_flush_icache_range(), but it's only used by hw/core/loader.c after writing to ROM, so it is expected to not apply here with RAM DEVICE. This fixes direct access to these regions where we don't want direct access. We'll extend cpu_memory_rw_debug() next to also be able to write to these (and IO) regions. This is a preparation for further changes. Cc: Alex Williamson Reviewed-by: Peter Xu Signed-off-by: David Hildenbrand Link: https://lore.kernel.org/r/20250210084648.33798-5-david@redhat.com Signed-off-by: Peter Xu --- diff --git a/system/physmem.c b/system/physmem.c index 235015f3ea..cff15ca1df 100644 --- a/system/physmem.c +++ b/system/physmem.c @@ -3137,8 +3137,7 @@ static inline MemTxResult address_space_write_rom_internal(AddressSpace *as, l = len; mr = address_space_translate(as, addr, &addr1, &l, true, attrs); - if (!(memory_region_is_ram(mr) || - memory_region_is_romd(mr))) { + if (!memory_region_supports_direct_access(mr)) { l = memory_access_size(mr, l, addr1); } else { /* ROM/RAM case */