From: Sami Wagiaalla Date: Thu, 23 Sep 2010 20:07:39 +0000 (+0000) Subject: Fix PR 12028: "GDB crashes on a double free during overload resolution " X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d44dc1289ee01fb527540b64c7f701b81bf4825f;p=thirdparty%2Fbinutils-gdb.git Fix PR 12028: "GDB crashes on a double free during overload resolution " 2010-09-23 Sami Wagiaalla PR C++/12028 * valops.c (find_oload_champ_namespace_loop): removed incorrect 'old_cleanups' reassignment. 2010-09-23 Sami Wagiaalla * gdb.cp/pr12028.cc: New. * gdb.cp/pr12028.exp: New. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 48db57812d0..b9ebe527de7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2010-09-23 Sami Wagiaalla + + PR C++/12028 + * valops.c (find_oload_champ_namespace_loop): removed incorrect + 'old_cleanups' reassignment. + 2010-09-08 Yao Qi Pedro Alves diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 8f81444b620..d75cb9f3b68 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2010-09-23 Sami Wagiaalla + + * gdb.cp/pr12028.cc: New. + * gdb.cp/pr12028.exp: New. + 2010-08-26 Yao Qi * gdb.dwarf2/dw2-ref-missing-frame-func.c: Add .p2align 4 for labels diff --git a/gdb/valops.c b/gdb/valops.c index 7fbad10ce34..4e83a04723a 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -2715,7 +2715,7 @@ find_oload_champ_namespace_loop (struct type **arg_types, int nargs, function symbol to start off with.) */ old_cleanups = make_cleanup (xfree, *oload_syms); - old_cleanups = make_cleanup (xfree, *oload_champ_bv); + make_cleanup (xfree, *oload_champ_bv); new_namespace = alloca (namespace_len + 1); strncpy (new_namespace, qualified_name, namespace_len); new_namespace[namespace_len] = '\0';