From: Etsuro Fujita <efujita@postgresql.org>
Date: Thu, 29 Sep 2022 07:55:01 +0000 (+0900)
Subject: Update comment in ExecInsert() regarding batch insertion.
X-Git-Tag: REL_15_RC2~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d460faf00285fd99d3c80e890c8f6fe798233b48;p=thirdparty%2Fpostgresql.git

Update comment in ExecInsert() regarding batch insertion.

Remove the stale text that is a leftover from an earlier version of the
patch to add support for batch insertion, and adjust the wording in the
remaining text.

Back-patch to v14 where batch insertion came in.

Review and wording adjustment by Tom Lane.

Discussion: https://postgr.es/m/CAPmGK14goatHPHQv2Aeu_UTKqZ%2BBO%2BP%2Bzd3HKv5D%2BdyyfWKDSw%40mail.gmail.com
---

diff --git a/src/backend/executor/nodeModifyTable.c b/src/backend/executor/nodeModifyTable.c
index 775960827d0..04454ad6e60 100644
--- a/src/backend/executor/nodeModifyTable.c
+++ b/src/backend/executor/nodeModifyTable.c
@@ -795,9 +795,8 @@ ExecInsert(ModifyTableContext *context,
 		if (resultRelInfo->ri_BatchSize > 1)
 		{
 			/*
-			 * If a certain number of tuples have already been accumulated, or
-			 * a tuple has come for a different relation than that for the
-			 * accumulated tuples, perform the batch insert
+			 * When we've reached the desired batch size, perform the
+			 * insertion.
 			 */
 			if (resultRelInfo->ri_NumSlots == resultRelInfo->ri_BatchSize)
 			{