From: Christopher Faulet <cfaulet@haproxy.com>
Date: Thu, 6 Feb 2025 16:13:50 +0000 (+0100)
Subject: BUG/MINOR: stats-json: Define JSON_INT_MAX as a signed integer
X-Git-Tag: v3.2-dev5~10
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d48b5add889db1bf2f0fae4721abb46413303d33;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stats-json: Define JSON_INT_MAX as a signed integer

A JSON integer is defined in the range [-(2**53)+1, (2**53)-1]. Macro are used
to define the minimum and the maximum value, The minimum one is defined using
the maximum one. So JSON_INT_MAX must be defined as a signed integer value to
avoid wrong cast of JSON_INT_MIN.

It was reported by Coverity in #2841: CID 1587769.

This patch could be backported to all stable versions.
---

diff --git a/src/stats-json.c b/src/stats-json.c
index b49385386..f66ac7389 100644
--- a/src/stats-json.c
+++ b/src/stats-json.c
@@ -60,7 +60,7 @@ static int stats_emit_json_field_tags(struct buffer *out, const struct field *f)
 /* Limit JSON integer values to the range [-(2**53)+1, (2**53)-1] as per
  * the recommendation for interoperable integers in section 6 of RFC 7159.
  */
-#define JSON_INT_MAX ((1ULL << 53) - 1)
+#define JSON_INT_MAX ((1LL << 53) - 1)
 #define JSON_INT_MIN (0 - JSON_INT_MAX)
 
 /* Emits a stats field value and its type in JSON.