From: Michael Tremer <michael.tremer@ipfire.org>
Date: Tue, 15 Aug 2023 09:48:35 +0000 (+0000)
Subject: mountfs: Remove excessive sync-ing before umount
X-Git-Tag: v2.27-core179~9^2~11
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d4a8484eb1805696b9147ef7cc873776d76f0c4e;p=ipfire-2.x.git

mountfs: Remove excessive sync-ing before umount

The system should perform all write operations when sync is called and
only return when the write queues are empty.

There is no additional benefit for calling sync again as the buffers
should be empty. If data is still being lost, then that is a bug in
either the storage device or driver.

As the (re-)boot process is already so slow, I would like to get rid of
any unnecessary delays.

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/initscripts/system/mountfs b/src/initscripts/system/mountfs
index 2e2ff0b5b6..8975eb02c7 100644
--- a/src/initscripts/system/mountfs
+++ b/src/initscripts/system/mountfs
@@ -45,9 +45,7 @@ case "${1}" in
 
 	stop)
 		boot_mesg "Syncing discs..."
-		sync && sync
-		sleep 2
-		sync && sync
+		sync
 		evaluate_retval
 
 		# ExtraHD