From: Andrew Pinski Date: Thu, 28 Oct 2004 23:38:47 +0000 (+0000) Subject: visibility-[1-9a].c: Change to use scan-hidden instead of scan-assembler. X-Git-Tag: releases/gcc-4.0.0~3591 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d533f1cb17580dea7f45d6ff7a1a371b796556e3;p=thirdparty%2Fgcc.git visibility-[1-9a].c: Change to use scan-hidden instead of scan-assembler. 2004-10-28 Andrew Pinski * gcc.dg/visibility-[1-9a].c: Change to use scan-hidden instead of scan-assembler. * lib/scanasm.exp (hidden-scan-for): New proc. (scan-hidden): Use hidden-scan-for instead of constructing the scan string. (scan-not-hidden): Likewise. * lib/target-supports.exp (check_visibility_available): mach-o is support too. From-SVN: r89793 --- diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 556d3301c259..c781e8bb28ea 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,14 @@ +2004-10-28 Andrew Pinski + + * gcc.dg/visibility-[1-9a].c: Change to use scan-hidden instead of + scan-assembler. + * lib/scanasm.exp (hidden-scan-for): New proc. + (scan-hidden): Use hidden-scan-for instead of constructing the scan + string. + (scan-not-hidden): Likewise. + * lib/target-supports.exp (check_visibility_available): mach-o is + support too. + 2004-10-28 Mark Mitchell PR c++/17132 diff --git a/gcc/testsuite/gcc.dg/visibility-1.c b/gcc/testsuite/gcc.dg/visibility-1.c index f76c3ca91547..864b971dd64c 100644 --- a/gcc/testsuite/gcc.dg/visibility-1.c +++ b/gcc/testsuite/gcc.dg/visibility-1.c @@ -1,7 +1,7 @@ /* Test visibility attribute on function definition. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*foo" } } */ +/* { dg-final { scan-hidden "foo" } } */ void __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/gcc.dg/visibility-2.c b/gcc/testsuite/gcc.dg/visibility-2.c index e62dbbb4cd52..0977abac2b8d 100644 --- a/gcc/testsuite/gcc.dg/visibility-2.c +++ b/gcc/testsuite/gcc.dg/visibility-2.c @@ -1,7 +1,7 @@ /* Test that visibility attribute on declaration extends to definition. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*foo" } } */ +/* { dg-final { scan-hidden "foo" } } */ void __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/gcc.dg/visibility-3.c b/gcc/testsuite/gcc.dg/visibility-3.c index e0bf01fb130a..cb5a71524f6b 100644 --- a/gcc/testsuite/gcc.dg/visibility-3.c +++ b/gcc/testsuite/gcc.dg/visibility-3.c @@ -1,7 +1,7 @@ /* Test visibility attribute on forward declaration of global variable */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*xyzzy" } } */ +/* { dg-final { scan-hidden "xyzzy" } } */ int __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/gcc.dg/visibility-4.c b/gcc/testsuite/gcc.dg/visibility-4.c index 1a0b3ca37dac..af0d461c3d9e 100644 --- a/gcc/testsuite/gcc.dg/visibility-4.c +++ b/gcc/testsuite/gcc.dg/visibility-4.c @@ -1,7 +1,7 @@ /* Test visibility attribute on forward declaration of global variable */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*xyzzy" } } */ +/* { dg-final { scan-hidden "xyzzy" } } */ extern int __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/gcc.dg/visibility-5.c b/gcc/testsuite/gcc.dg/visibility-5.c index b1f46d2040a8..0302768c91b4 100644 --- a/gcc/testsuite/gcc.dg/visibility-5.c +++ b/gcc/testsuite/gcc.dg/visibility-5.c @@ -2,7 +2,7 @@ already had a forward declaration. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*foo" } } */ +/* { dg-final { scan-hidden "foo" } } */ void foo(); diff --git a/gcc/testsuite/gcc.dg/visibility-6.c b/gcc/testsuite/gcc.dg/visibility-6.c index 632f2ac20592..4e9deebec373 100644 --- a/gcc/testsuite/gcc.dg/visibility-6.c +++ b/gcc/testsuite/gcc.dg/visibility-6.c @@ -2,7 +2,7 @@ already had a forward declaration. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*xyzzy" } } */ +/* { dg-final { scan-hidden "xyzzy" } } */ extern int xyzzy; diff --git a/gcc/testsuite/gcc.dg/visibility-7.c b/gcc/testsuite/gcc.dg/visibility-7.c index 5bdc2b028086..f5e6e9aae5ce 100644 --- a/gcc/testsuite/gcc.dg/visibility-7.c +++ b/gcc/testsuite/gcc.dg/visibility-7.c @@ -1,7 +1,7 @@ /* Test warning from conflicting visibility specifications. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*xyzzy" } } */ +/* { dg-final { scan-hidden "xyzzy" } } */ extern int __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/gcc.dg/visibility-8.c b/gcc/testsuite/gcc.dg/visibility-8.c index fc3a1055757d..89f89c0822bd 100644 --- a/gcc/testsuite/gcc.dg/visibility-8.c +++ b/gcc/testsuite/gcc.dg/visibility-8.c @@ -2,7 +2,7 @@ /* { dg-do compile } */ /* { dg-options "-std=gnu99" } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*__GI_fputs_unlocked" } } */ +/* { dg-final { scan-hidden "__GI_fputs_unlocked" } } */ int fputs_unlocked (const char *restrict, int *restrict) __asm__ ("__GI_fputs_unlocked") diff --git a/gcc/testsuite/gcc.dg/visibility-9.c b/gcc/testsuite/gcc.dg/visibility-9.c index ac6493ef323e..9d575168491b 100644 --- a/gcc/testsuite/gcc.dg/visibility-9.c +++ b/gcc/testsuite/gcc.dg/visibility-9.c @@ -2,7 +2,7 @@ /* { dg-do compile } */ /* { dg-require-visibility "" } */ /* { dg-options "-fvisibility=hidden" } */ -/* { dg-final { scan-assembler "\\.hidden.*foo" } } */ +/* { dg-final { scan-hidden "foo" } } */ void foo(); diff --git a/gcc/testsuite/gcc.dg/visibility-a.c b/gcc/testsuite/gcc.dg/visibility-a.c index 17492342f15e..23a51d7e5a4e 100644 --- a/gcc/testsuite/gcc.dg/visibility-a.c +++ b/gcc/testsuite/gcc.dg/visibility-a.c @@ -1,7 +1,7 @@ /* Test that #pragma GCC visibility works. */ /* { dg-do compile } */ /* { dg-require-visibility "" } */ -/* { dg-final { scan-assembler "\\.hidden.*foo" } } */ +/* { dg-final { scan-hidden "foo" } } */ #pragma GCC visibility push(hidden) void foo(); diff --git a/gcc/testsuite/gcc.dg/visibility-b.c b/gcc/testsuite/gcc.dg/visibility-b.c index b1f15758aa2d..8b0c41dd59d7 100644 --- a/gcc/testsuite/gcc.dg/visibility-b.c +++ b/gcc/testsuite/gcc.dg/visibility-b.c @@ -1,4 +1,6 @@ -/* { dg-do assemble { target *-*-darwin* } } */ +/* { dg-do compile } */ +/* { dg-require-visibility "" } */ +/* { dg-final { scan-hidden "n" } } */ #define __private_extern__ extern __attribute__((visibility ("hidden"))) diff --git a/gcc/testsuite/lib/scanasm.exp b/gcc/testsuite/lib/scanasm.exp index 9116afc1c419..33c574ac34c9 100644 --- a/gcc/testsuite/lib/scanasm.exp +++ b/gcc/testsuite/lib/scanasm.exp @@ -79,6 +79,21 @@ proc scan-assembler-not { args } { dg-scan "scan-assembler-not" 0 $testcase $output_file $args } +# Return the scan for the assembly for hidden visibility. + +proc hidden-scan-for { symbol } { + + set objformat [gcc_target_object_format] + + switch $objformat { + elf { return "hidden\[ \t_\]*$symbol" } + mach-o { return "private_extern\[ \t_\]*_?$symbol" } + default { return "" } + } + +} + + # Check that a symbol is defined as a hidden symbol in the .s file # produced by the compiler. @@ -87,7 +102,10 @@ proc scan-hidden { args } { set output_file "[file rootname [file tail $testcase]].s" set symbol [lindex $args 0] - set args [lreplace $args 0 0 "hidden\[ \t_\]*$symbol"] + + set hidden_scan [hidden-scan-for $symbol] + + set args [lreplace $args 0 0 "$hidden_scan"] dg-scan "scan-hidden" 1 $testcase $output_file $args } @@ -100,7 +118,9 @@ proc scan-not-hidden { args } { set output_file "[file rootname [file tail $testcase]].s" set symbol [lindex $args 0] - set args [lreplace $args 0 0 "hidden\[ \t_\]*$symbol"] + set hidden_scan [hidden-scan-for symbol] + + set args [lreplace $args 0 0 "$hidden_scan"] dg-scan "scan-not-hidden" 0 $testcase $output_file $args } diff --git a/gcc/testsuite/lib/target-supports.exp b/gcc/testsuite/lib/target-supports.exp index a737f5db186f..b968de275a16 100644 --- a/gcc/testsuite/lib/target-supports.exp +++ b/gcc/testsuite/lib/target-supports.exp @@ -88,6 +88,7 @@ proc check_visibility_available { } { switch $objformat { elf { return 1 } + mach-o { return 1 } unknown { return -1 } default { return 0 } }