From: Patrick Steinhardt Date: Mon, 13 May 2024 08:47:01 +0000 (+0200) Subject: reftable/block: use `size_t` to track restart point index X-Git-Tag: v2.46.0-rc0~90^2~12 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d537ce6b9ed75d50c6b8ad071439b06c1b70c5f8;p=thirdparty%2Fgit.git reftable/block: use `size_t` to track restart point index The function `block_reader_restart_offset()` gets the offset of the `i`th restart point. `i` is a signed integer though, which is certainly not the correct type to track indices like this. Furthermore, both callers end up passing a `size_t`. Refactor the code to use a `size_t` instead. Signed-off-by: Patrick Steinhardt Signed-off-by: Junio C Hamano --- diff --git a/reftable/block.c b/reftable/block.c index 5942cb4053..00030eee06 100644 --- a/reftable/block.c +++ b/reftable/block.c @@ -326,9 +326,9 @@ int block_reader_first_key(const struct block_reader *br, struct strbuf *key) return 0; } -static uint32_t block_reader_restart_offset(const struct block_reader *br, int i) +static uint32_t block_reader_restart_offset(const struct block_reader *br, size_t idx) { - return get_be24(br->restart_bytes + 3 * i); + return get_be24(br->restart_bytes + 3 * idx); } void block_iter_seek_start(struct block_iter *it, const struct block_reader *br)