From: Jeff King <peff@peff.net>
Date: Wed, 10 Jul 2024 08:35:57 +0000 (-0400)
Subject: chainlint.pl: do not spawn more threads than we have scripts
X-Git-Tag: v2.46.0-rc1~12^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d558509e2527abaf0faf1f93cad775eeeada0d17;p=thirdparty%2Fgit.git

chainlint.pl: do not spawn more threads than we have scripts

The chainlint.pl script spawns worker threads to check many scripts in
parallel. This is good if you feed it a lot of scripts. But if you give
it few (or one), then the overhead of spawning the threads dominates. We
can easily notice that we have fewer scripts than threads and scale back
as appropriate.

This patch reduces the time to run:

  time for i in chainlint/*.test; do
	perl chainlint.pl $i
  done >/dev/null

on my system from ~4.1s to ~1.1s, where I have 8+8 cores.

As with the previous patch, this isn't the usual way we run chainlint
(we feed many scripts at once, which is why it supports threading in the
first place). So this won't make a big difference in the real world, but
it may help us out in the future, and it makes experimenting with and
debugging the chainlint tests a bit more pleasant.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/chainlint.pl b/t/chainlint.pl
index 1864d048ae..118a229a96 100755
--- a/t/chainlint.pl
+++ b/t/chainlint.pl
@@ -806,6 +806,7 @@ unless (@scripts) {
 	show_stats($start_time, \@stats) if $show_stats;
 	exit;
 }
+$jobs = @scripts if @scripts < $jobs;
 
 unless ($jobs > 1 &&
 	$Config{useithreads} && eval {