From: Tom de Vries <tdevries@suse.de>
Date: Wed, 27 Aug 2025 06:28:34 +0000 (+0200)
Subject: [gdb/testsuite] Add missing require {!is_remote host}
X-Git-Tag: gdb-17-branchpoint~165
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d59c2b35c07805a0cd3146b018808732e61adae3;p=thirdparty%2Fbinutils-gdb.git

[gdb/testsuite] Add missing require {!is_remote host}

I ran test-case gdb.python/py-color-pagination.exp with make-check-all.sh and
noticed failures when using remote host.

So I grepped to find all test-cases using with_ansi_styling_terminal and ran
them with host/target board local-remote-host-native.

Fix the failing test-cases using require {!is_remote host}.

Tested on x86_64-linux.
---

diff --git a/gdb/testsuite/gdb.guile/scm-color.exp b/gdb/testsuite/gdb.guile/scm-color.exp
index 578f712201d..4c6a9c2bee6 100644
--- a/gdb/testsuite/gdb.guile/scm-color.exp
+++ b/gdb/testsuite/gdb.guile/scm-color.exp
@@ -19,6 +19,7 @@
 load_lib gdb-guile.exp
 
 require allow_guile_tests
+require {!is_remote host}
 
 # Start GDB with styling support.
 with_ansi_styling_terminal {
diff --git a/gdb/testsuite/gdb.python/py-color-pagination.exp b/gdb/testsuite/gdb.python/py-color-pagination.exp
index 3235fffe5cc..ad9ae9b71e5 100644
--- a/gdb/testsuite/gdb.python/py-color-pagination.exp
+++ b/gdb/testsuite/gdb.python/py-color-pagination.exp
@@ -19,6 +19,7 @@
 load_lib gdb-python.exp
 
 require allow_python_tests
+require {!is_remote host}
 
 standard_testfile
 
diff --git a/gdb/testsuite/gdb.python/py-color.exp b/gdb/testsuite/gdb.python/py-color.exp
index 2601cf37836..08089e5b7b5 100644
--- a/gdb/testsuite/gdb.python/py-color.exp
+++ b/gdb/testsuite/gdb.python/py-color.exp
@@ -18,6 +18,7 @@
 load_lib gdb-python.exp
 
 require allow_python_tests
+require {!is_remote host}
 
 # Start with a fresh GDB, but enable color support.
 with_ansi_styling_terminal {
diff --git a/gdb/testsuite/gdb.python/py-format-string.exp b/gdb/testsuite/gdb.python/py-format-string.exp
index 114a6065b31..2463185aab4 100644
--- a/gdb/testsuite/gdb.python/py-format-string.exp
+++ b/gdb/testsuite/gdb.python/py-format-string.exp
@@ -1202,7 +1202,9 @@ with_test_prefix "format_string" {
 	set current_lang "c"
 	prepare_gdb "${binfile}"
 	test_all_common
-	test_styling
+	if { ![is_remote host] } {
+	    test_styling
+	}
       }
     }
   }
diff --git a/gdb/testsuite/gdb.python/py-startup-opt.exp b/gdb/testsuite/gdb.python/py-startup-opt.exp
index 74107063c20..929c64d21e4 100644
--- a/gdb/testsuite/gdb.python/py-startup-opt.exp
+++ b/gdb/testsuite/gdb.python/py-startup-opt.exp
@@ -17,6 +17,7 @@
 # initialized.
 
 require allow_python_tests
+require {!is_remote host}
 
 # Return a list containing two directory paths for newly created home
 # directories.
diff --git a/gdb/testsuite/gdb.python/py-styled-execute.exp b/gdb/testsuite/gdb.python/py-styled-execute.exp
index 0b27c638eb6..198dab52ddd 100644
--- a/gdb/testsuite/gdb.python/py-styled-execute.exp
+++ b/gdb/testsuite/gdb.python/py-styled-execute.exp
@@ -17,6 +17,7 @@
 # on the value of the third argument passed to gdb.execute.
 
 require allow_python_tests
+require {!is_remote host}
 
 load_lib gdb-python.exp