From: Marek Schimara Date: Thu, 16 Jun 2016 11:45:54 +0000 (+0200) Subject: src/rrd_daemon.c: fix Coverity CID#26525 Buffer not null terminated X-Git-Tag: v1.7.0~42^2~31 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d5ca93eed507f5080beab6e5e0dd5d97730ddc76;p=thirdparty%2Frrdtool-1.x.git src/rrd_daemon.c: fix Coverity CID#26525 Buffer not null terminated CWE-170 / https://cwe.mitre.org/data/definitions/170.html --- diff --git a/src/rrd_daemon.c b/src/rrd_daemon.c index 6e8e687e..65b7c2c0 100644 --- a/src/rrd_daemon.c +++ b/src/rrd_daemon.c @@ -1500,8 +1500,10 @@ static int handle_request_update (HANDLER_PROTO) /* {{{ */ cache_item_t *ci; /* save it for the journal later */ - if (!JOURNAL_REPLAY(sock)) + if (!JOURNAL_REPLAY(sock)) { strncpy(orig_buf, buffer, min(RRD_CMD_MAX,buffer_size)); + orig_buf[min(RRD_CMD_MAX,buffer_size) - 1] = '\0'; + } status = buffer_get_field (&buffer, &buffer_size, &pbuffile); if (status != 0) {