From: Daniel Stenberg <daniel@haxx.se>
Date: Mon, 20 Jun 2022 07:00:12 +0000 (+0200)
Subject: easy: remove dead code
X-Git-Tag: curl-7_84_0~23
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d5dc3629eb69b916414f10db05f493a5625ad7ee;p=thirdparty%2Fcurl.git

easy: remove dead code

Follow-up from 5912da253b64d

Detected by Coverity (CID 1506519)

Closes #9029
---

diff --git a/lib/easy.c b/lib/easy.c
index aa642015fe..704a59df62 100644
--- a/lib/easy.c
+++ b/lib/easy.c
@@ -575,14 +575,16 @@ static CURLcode wait_or_timeout(struct Curl_multi *multi, struct events *ev)
 
     ev->msbump = FALSE; /* reset here */
 
-    if(0 == pollrc) {
+    if(!pollrc) {
       /* timeout! */
       ev->ms = 0;
       /* fprintf(stderr, "call curl_multi_socket_action(TIMEOUT)\n"); */
       mcode = curl_multi_socket_action(multi, CURL_SOCKET_TIMEOUT, 0,
                                        &ev->running_handles);
     }
-    else if(pollrc > 0) {
+    else {
+      /* here pollrc is > 0 */
+
       /* loop over the monitored sockets to see which ones had activity */
       for(i = 0; i< numfds; i++) {
         if(fds[i].revents) {
@@ -608,8 +610,6 @@ static CURLcode wait_or_timeout(struct Curl_multi *multi, struct events *ev)
         }
       }
     }
-    else
-      return CURLE_RECV_ERROR;
 
     if(mcode)
       return CURLE_URL_MALFORMAT;