From: Stefan Schantl <stefan.schantl@ipfire.org>
Date: Wed, 30 Jan 2019 08:39:17 +0000 (+0100)
Subject: ids.cgi: Only show "update ruleset" button if a ruleset is present
X-Git-Tag: suricata-rc1~50
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d618d67e010e94e1ef26f2570abe9d6748e90416;p=people%2Fstevee%2Fipfire-2.x.git

ids.cgi: Only show "update ruleset" button if a ruleset is present

Signed-off-by: Stefan Schantl <stefan.schantl@ipfire.org>
---

diff --git a/html/cgi-bin/ids.cgi b/html/cgi-bin/ids.cgi
index 1bb193ad95..61993a243a 100644
--- a/html/cgi-bin/ids.cgi
+++ b/html/cgi-bin/ids.cgi
@@ -826,19 +826,10 @@ print <<END
 			<td align='right'>
 END
 ;
-		# Check if a ruleset source has been configured yet.
-		unless($rulessettings{'RULES'}) {
-			# If no ruleset settings have been saved yet, disable the button to download / update the ruleset.
-			print"<input type='submit' name='RULESET' disabled='disabled' value='$Lang::tr{'download new ruleset'}'>\n";
-		} else {
-			# Ruleset setting have been saved. - Check if a ruleset already is downloaded.
+			# Check if a ruleset has been downloaded yet.
 			if (%idsrules) {
-				# Allow to press the button and show it as "update ruleset".
+				# Display button to update the ruleset.
 				print"<input type='submit' name='RULESET' value='$Lang::tr{'update ruleset'}'>\n";
-			} else {
-				# Also allow to press the button, but show it as "download new ruleset".
-				print"<input type='submit' name='RULESET' value='$Lang::tr{'download new ruleset'}'>\n";
-			}
 		}
 print <<END;
 				<input type='submit' name='RULESET' value='$Lang::tr{'save'}'>