From: Darrick J. Wong Date: Fri, 7 May 2021 14:42:17 +0000 (-0400) Subject: libxfs: copy crtime correctly now that it's timespec64 X-Git-Tag: v5.12.0-rc1~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d625f74125863304d111f5c6a0817a115f8e502d;p=thirdparty%2Fxfsprogs-dev.git libxfs: copy crtime correctly now that it's timespec64 The incore i_mtime and di_crtime are both timespec64 now, which means that tv_sec is a 64-bit value. Don't cast that to int32_t when we're creating an inode, because we'll end up truncating the creation time incorrectly, should an xfsprogs of this vintage make it to 2039. :P Signed-off-by: Darrick J. Wong Reviewed-by: Christoph Hellwig Signed-off-by: Eric Sandeen --- diff --git a/libxfs/util.c b/libxfs/util.c index 1025ad246..a49aee9e7 100644 --- a/libxfs/util.c +++ b/libxfs/util.c @@ -290,8 +290,7 @@ libxfs_init_new_inode( VFS_I(ip)->i_version = 1; ip->i_d.di_flags2 = pip ? ip->i_mount->m_ino_geo.new_diflags2 : xfs_flags2diflags2(ip, fsx->fsx_xflags); - ip->i_d.di_crtime.tv_sec = (int32_t)VFS_I(ip)->i_mtime.tv_sec; - ip->i_d.di_crtime.tv_nsec = (int32_t)VFS_I(ip)->i_mtime.tv_nsec; + ip->i_d.di_crtime = VFS_I(ip)->i_mtime; /* struct copy */ ip->i_d.di_cowextsize = pip ? 0 : fsx->fsx_cowextsize; }