From: Bernd Edlinger <bernd.edlinger@hotmail.de>
Date: Sun, 3 Dec 2023 10:41:51 +0000 (+0100)
Subject: Fix a possible memleak in opt_verify
X-Git-Tag: openssl-3.3.0-alpha1~493
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d6688e45fa2f987f3ffd324e19922468beee5ddc;p=thirdparty%2Fopenssl.git

Fix a possible memleak in opt_verify

The ASN1_OBJECT otmp was leaked if X509_VERIFY_PARAM_add0_policy fails.

Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22922)
---

diff --git a/apps/lib/opt.c b/apps/lib/opt.c
index 2d61ac9a786..0490c39c251 100644
--- a/apps/lib/opt.c
+++ b/apps/lib/opt.c
@@ -726,7 +726,12 @@ int opt_verify(int opt, X509_VERIFY_PARAM *vpm)
             opt_printf_stderr("%s: Invalid Policy %s\n", prog, opt_arg());
             return 0;
         }
-        X509_VERIFY_PARAM_add0_policy(vpm, otmp);
+        if (!X509_VERIFY_PARAM_add0_policy(vpm, otmp)) {
+            ASN1_OBJECT_free(otmp);
+            opt_printf_stderr("%s: Internal error adding Policy %s\n",
+                              prog, opt_arg());
+            return 0;
+        }
         break;
     case OPT_V_PURPOSE:
         /* purpose name -> purpose index */