From: Henrik Nordstrom <henrik@henriknordstrom.net>
Date: Sun, 26 Jul 2009 21:22:41 +0000 (+0200)
Subject: const violation detected by GCC in how ftp.cc parsed login details
X-Git-Tag: SQUID_3_2_0_1~837
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d6a8572bc7debb7934f57bbcabc6f705e9ab8544;p=thirdparty%2Fsquid.git

const violation detected by GCC in how ftp.cc parsed login details
---

diff --git a/src/ftp.cc b/src/ftp.cc
index 753ccb60ce..603bc2b312 100644
--- a/src/ftp.cc
+++ b/src/ftp.cc
@@ -532,9 +532,11 @@ FtpStateData::~FtpStateData()
  * Produces filled member varisbles user, password, password_url if anything found.
  */
 void
-FtpStateData::loginParser(const char *login, int escaped)
+FtpStateData::loginParser(const char *login_, int escaped)
 {
+    char *login = xstrdup(login_);
     char *s = NULL;
+
     debugs(9, 4, HERE << ": login='" << login << "', escaped=" << escaped);
     debugs(9, 9, HERE << ": IN : login='" << login << "', escaped=" << escaped << ", user=" << user << ", password=" << password);
 
@@ -564,6 +566,7 @@ FtpStateData::loginParser(const char *login, int escaped)
     }
 
     debugs(9, 9, HERE << ": OUT: login='" << login << "', escaped=" << escaped << ", user=" << user << ", password=" << password);
+    safe_free(login);
 }
 
 void