From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 28 Mar 2018 14:34:29 +0000 (+0200)
Subject: video: ARM CLCD: Improve a size determination in clcdfb_probe()
X-Git-Tag: v4.17-rc1~63^2~5
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d6f586163f86e91c34ccca72e2d9374bc77d990a;p=thirdparty%2Flinux.git

video: ARM CLCD: Improve a size determination in clcdfb_probe()

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Cc: Russell King <linux@armlinux.org.uk>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---

diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
index 79f5ebf23fcd9..38c1f324ce15d 100644
--- a/drivers/video/fbdev/amba-clcd.c
+++ b/drivers/video/fbdev/amba-clcd.c
@@ -967,7 +967,7 @@ static int clcdfb_probe(struct amba_device *dev, const struct amba_id *id)
 		goto out;
 	}
 
-	fb = kzalloc(sizeof(struct clcd_fb), GFP_KERNEL);
+	fb = kzalloc(sizeof(*fb), GFP_KERNEL);
 	if (!fb) {
 		ret = -ENOMEM;
 		goto free_region;