From: Markus Armbruster <armbru@redhat.com>
Date: Mon, 25 Jan 2021 13:26:35 +0000 (+0100)
Subject: error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"
X-Git-Tag: v6.0.0-rc0~62^2~3
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d71a243220db1e6bc04425b5988b8a9bc8523345;p=thirdparty%2Fqemu.git

error: Fix "Converting to ERRP_GUARD()" doc on "valid at return"

Setting errp = NULL is wrong: the automatic error propagation still
propagates the dangling pointer _auto_errp_prop.local_err.  We need to
set *errp = NULL to clear the dangling pointer.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210125132635.1253219-1-armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---

diff --git a/include/qapi/error.h b/include/qapi/error.h
index eaa05c48374..4a9260b0cc0 100644
--- a/include/qapi/error.h
+++ b/include/qapi/error.h
@@ -235,7 +235,7 @@
  *    error_propagate_prepend(errp, *errp, ...) by error_prepend(errp, ...)
  *
  * 4. Ensure @errp is valid at return: when you destroy *errp, set
- *    errp = NULL.
+ *    *errp = NULL.
  *
  * Example:
  *