From: Karel Zak <kzak@redhat.com>
Date: Tue, 4 Jun 2024 11:19:13 +0000 (+0200)
Subject: scriptreplay: fix uninitialized value [coverity scan]
X-Git-Tag: v2.42-start~307
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d7282ef8b3b030bbecee4264ae7674e0bf08d52c;p=thirdparty%2Futil-linux.git

scriptreplay: fix uninitialized value [coverity scan]

* fix uninitialized value "rc"

* simplify if(rc) block

Signed-off-by: Karel Zak <kzak@redhat.com>
---

diff --git a/term-utils/scriptreplay.c b/term-utils/scriptreplay.c
index 7535c8586..a2afd1c86 100644
--- a/term-utils/scriptreplay.c
+++ b/term-utils/scriptreplay.c
@@ -168,7 +168,7 @@ main(int argc, char *argv[])
 		   *log_tm = NULL;
 	double divi = 1;
 	int diviopt = FALSE, idx;
-	int ch, rc, crmode = REPLAY_CRMODE_AUTO, summary = 0;
+	int ch, rc = 0, crmode = REPLAY_CRMODE_AUTO, summary = 0;
 	enum {
 		OPT_SUMMARY = CHAR_MAX + 1
 	};
@@ -340,13 +340,12 @@ main(int argc, char *argv[])
 					replay_set_delay_div(setup, divi);
 				} else if (ch == 'C') { /* Right arrow */
 					rc = replay_emit_step_data(setup, step, STDOUT_FILENO);
-					if (!rc) {
+					if (!rc)
 						rc = replay_get_next_step(setup, streams, &step);
-						if (!rc) {
-							struct timeval *delay = replay_step_get_delay(step);
-							if (delay && timerisset(delay))
-								step_delay = *delay;
-						}
+					if (!rc) {
+						struct timeval *delay = replay_step_get_delay(step);
+						if (delay && timerisset(delay))
+							step_delay = *delay;
 					}
 				}
 			}
@@ -373,7 +372,7 @@ main(int argc, char *argv[])
 			rc = replay_emit_step_data(setup, step, STDOUT_FILENO);
 		if (rc)
 			break;
-		
+
 		rc = replay_get_next_step(setup, streams, &step);
 		if (rc)
 			break;