From: Timo Sirainen <timo.sirainen@open-xchange.com>
Date: Mon, 24 Aug 2020 16:10:10 +0000 (+0300)
Subject: imap: Delay initializing client IO until client_create_finish()
X-Git-Tag: 2.3.13~36
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d75fbac7f87d1a4163cb5f3b196b21ade0afe576;p=thirdparty%2Fdovecot%2Fcore.git

imap: Delay initializing client IO until client_create_finish()

This helps writing unit tests.
---

diff --git a/src/imap/imap-client.c b/src/imap/imap-client.c
index b37b829e13..22443624fe 100644
--- a/src/imap/imap-client.c
+++ b/src/imap/imap-client.c
@@ -143,7 +143,6 @@ struct client *client_create(int fd_in, int fd_out,
 	o_stream_set_flush_callback(client->output, client_output, client);
 
 	p_array_init(&client->module_contexts, client->pool, 5);
-	client->io = io_add_istream(client->input, client_input, client);
         client->last_input = ioloop_time;
 	client->to_idle = timeout_add(CLIENT_IDLE_TIMEOUT_MSECS,
 				      client_idle_timeout, client);
@@ -228,6 +227,7 @@ int client_create_finish(struct client *client, const char **error_r)
 		return -1;
 	mail_namespaces_set_storage_callbacks(client->user->namespaces,
 					      &mail_storage_callbacks, client);
+	client->io = io_add_istream(client->input, client_input, client);
 
 	client->v.init(client);
 	return 0;