From: Otto Moerbeek <otto.moerbeek@open-xchange.com>
Date: Wed, 21 Oct 2020 10:17:30 +0000 (+0200)
Subject: Add a comment: should we add the udr flag if !udrEnabled?
X-Git-Tag: dnsdist-1.6.0-alpha0~11^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d78bcadcc63dfeb4e18547b0ece1ffa6ff3a54be;p=thirdparty%2Fpdns.git

Add a comment: should we add the udr flag if !udrEnabled?
---

diff --git a/pdns/pdns_recursor.cc b/pdns/pdns_recursor.cc
index 3afc625535..9d8daeaa07 100644
--- a/pdns/pdns_recursor.cc
+++ b/pdns/pdns_recursor.cc
@@ -1812,6 +1812,7 @@ static void startDoResolve(void *p)
 #ifdef HAVE_PROTOBUF
         if (t_protobufServers) {
 #ifdef NOD_ENABLED
+          // if (g_udrEnabled) ?
           pbMessage->addRR(*i, luaconfsLocal->protobufExportConfig.exportTypes, udr);
 #else
           pbMessage->addRR(*i, luaconfsLocal->protobufExportConfig.exportTypes);
@@ -1876,6 +1877,7 @@ static void startDoResolve(void *p)
         pbMessage->getResponseBuf(),
         !appliedPolicy.getName().empty() || !dc->d_policyTags.empty()});
 #ifdef NOD_ENABLED
+      // if (g_udrEnabled) ??
       pbMessage->clearUDR(pbDataForCache->d_response);
 #endif
       // Below are the fields that are not stored in the packet cache and will be appended here and on a cache hit