From: hno <>
Date: Sat, 6 Apr 2002 18:25:46 +0000 (+0000)
Subject: Fix a memory leak on http_reply_access deny ...
X-Git-Tag: SQUID_3_0_PRE1~1124
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d803376314ae12683479d11778e7c636458502a0;p=thirdparty%2Fsquid.git

Fix a memory leak on http_reply_access deny ...
---

diff --git a/src/client_side.cc b/src/client_side.cc
index 05b2eaf754..e73afea23c 100644
--- a/src/client_side.cc
+++ b/src/client_side.cc
@@ -1,6 +1,6 @@
 
 /*
- * $Id: client_side.cc,v 1.568 2002/04/04 21:33:26 hno Exp $
+ * $Id: client_side.cc,v 1.569 2002/04/06 11:25:46 hno Exp $
  *
  * DEBUG: section 33    Client-side Routines
  * AUTHOR: Duane Wessels
@@ -1581,6 +1581,8 @@ clientSendMoreData(void *data, char *retbuf, ssize_t retsize)
 	    ch = aclChecklistCreate(Config.accessList.reply, http->request, NULL);
 	    ch->reply = rep;
 	    rv = aclCheckFast(Config.accessList.reply, ch);
+	    aclChecklistFree(ch);
+	    ch = NULL;
 	    debug(33, 2) ("The reply for %s %s is %s, because it matched '%s'\n",
 		RequestMethodStr[http->request->method], http->uri,
 		rv ? "ALLOWED" : "DENIED",
@@ -1602,7 +1604,6 @@ clientSendMoreData(void *data, char *retbuf, ssize_t retsize)
 		httpReplyDestroy(rep);
 		return;
 	    }
-	    aclChecklistFree(ch);
 	} else if (size < HTTP_REQBUF_SZ && entry->store_status == STORE_PENDING) {
 	    /* wait for more to arrive */
 	    http->reqofs += retsize;