From: Daan De Meyer <daan.j.demeyer@gmail.com>
Date: Thu, 18 Jul 2024 14:50:09 +0000 (+0200)
Subject: Only pass kernel command line to ukify if there is one
X-Git-Tag: v24~27
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d81b9141bde7b25cdf5b177fe987fa8d2916e189;p=thirdparty%2Fmkosi.git

Only pass kernel command line to ukify if there is one

If we don't have any kernel command line arguments, don't pass
--cmdline to ukify.

Turns out systemd-stub will hang on boot when .cmdline contains only
a null terminator so with this change we avoid that from happening.
---

diff --git a/mkosi/__init__.py b/mkosi/__init__.py
index 3d3443f1f..44b66169e 100644
--- a/mkosi/__init__.py
+++ b/mkosi/__init__.py
@@ -2126,7 +2126,7 @@ def build_uki(
     cmd: list[PathString] = [
         python_binary(context.config, binary=ukify),
         ukify,
-        "--cmdline", f"@{context.workspace / 'cmdline'}",
+        *(["--cmdline", f"@{context.workspace / 'cmdline'}"] if cmdline else []),
         "--os-release", f"@{context.root / 'usr/lib/os-release'}",
         "--stub", stub,
         "--output", output,