From: Colin Ian King Date: Tue, 28 Nov 2017 18:12:34 +0000 (+0000) Subject: scsi: wd719x: make card_types static const, shrinks object size X-Git-Tag: v4.16-rc1~140^2~276 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=d828e5c6d7a0bdca824481189bb7a911a6bf2d31;p=thirdparty%2Flinux.git scsi: wd719x: make card_types static const, shrinks object size Don't populate the read-only array card_types on the stack but instead make it static and constify it. Makes the object code smaller by over 110 bytes: Before: text data bss dec hex filename 25625 5752 0 31377 7a91 drivers/scsi/wd719x.o After: text data bss dec hex filename 25447 5816 0 31263 7a1f drivers/scsi/wd719x.o (gcc version 7.2.0 x86_64) Signed-off-by: Colin Ian King Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/wd719x.c b/drivers/scsi/wd719x.c index 2a9da2e0ea6ba..2ba2b7b47f417 100644 --- a/drivers/scsi/wd719x.c +++ b/drivers/scsi/wd719x.c @@ -803,7 +803,9 @@ static enum wd719x_card_type wd719x_detect_type(struct wd719x *wd) static int wd719x_board_found(struct Scsi_Host *sh) { struct wd719x *wd = shost_priv(sh); - char *card_types[] = { "Unknown card", "WD7193", "WD7197", "WD7296" }; + static const char * const card_types[] = { + "Unknown card", "WD7193", "WD7197", "WD7296" + }; int ret; INIT_LIST_HEAD(&wd->active_scbs);